git » sdk » commit 5181b52

Remove stuff that didn't prove to be necessary

author Eric Roberts
2026-08-25 11:53:49 UTC
committer Stephen Paul Weber
2026-08-25 11:55:31 UTC
parent 041e2c5669baef0fb93c88f3d2056d54138fe66d

Remove stuff that didn't prove to be necessary

After doing some more testing I realized there were some bits of this that
weren't needed. calling dispose for example is unnecessary because everything
will get cleaned up at the end of the test anyway.

There was an unnecessary await.

reuseExistingServer just seems confusing and unnecessary.

playwright.config.ts +0 -1
test/browser-test.ts +1 -6

diff --git a/playwright.config.ts b/playwright.config.ts
index 5f706e5..74f3109 100644
--- a/playwright.config.ts
+++ b/playwright.config.ts
@@ -17,7 +17,6 @@ export default defineConfig({
 	webServer: {
 		command: "node playwright/server.mjs",
 		url: "http://127.0.0.1:49276",
-		reuseExistingServer: !process.env.CI,
 	},
 	/* Run tests in files in parallel */
 	fullyParallel: true,
diff --git a/test/browser-test.ts b/test/browser-test.ts
index 685a9f6..39a2da9 100644
--- a/test/browser-test.ts
+++ b/test/browser-test.ts
@@ -25,15 +25,13 @@ export const idbTest = base.extend<BrowserFixtures>({
 	borogove: async ({ page }, use) => {
 		const borogove = await page.evaluateHandle(() => window.borogove);
 		await use(borogove);
-		await borogove.dispose();
 	},
 	persistence: async ({ page, borogove }, use) => {
 		const persistence = await page.evaluateHandle(async (borogove) => {
 			const mediaStore = await borogove.persistence.MediaStoreCache("snikket");
-			return await borogove.persistence.IDB("snikket", mediaStore);
+			return borogove.persistence.IDB("snikket", mediaStore);
 		}, borogove);
 		await use(persistence);
-		await persistence.dispose();
 	},
 });
 
@@ -45,12 +43,10 @@ export const sqliteTest = base.extend<SqliteFixtures>({
 	borogove: async ({ page }, use) => {
 		const borogove = await page.evaluateHandle(() => window.borogove);
 		await use(borogove);
-		await borogove.dispose();
 	},
 	sqlite: async ({ page }, use) => {
 		const sqlite = await page.evaluateHandle(() => window.sqlite);
 		await use(sqlite);
-		await sqlite.dispose();
 	},
 	persistence: async ({ page, borogove, sqlite }, use) => {
 		const persistence = await page.evaluateHandle(
@@ -62,7 +58,6 @@ export const sqliteTest = base.extend<SqliteFixtures>({
 			{ borogove, sqlite },
 		);
 		await use(persistence);
-		await persistence.dispose();
 	},
 });