git » sdk » commit 7595ca8

Don't catch exceptions just to cause a more confusing one

author Stephen Paul Weber
2024-10-21 15:40:20 UTC
committer Stephen Paul Weber
2024-10-21 15:40:20 UTC
parent 41249a48c7e481333566a929f637b9a4f48d7ff9
Don't catch exceptions just to cause a more confusing one

Any exception that happens in callback is bad, but calling
callback(null) after already calling callback with something else just
causes a less helpful exception.
snikket/streams/XmppJsStream.hx +5 -8 
diff --git a/snikket/streams/XmppJsStream.hx b/snikket/streams/XmppJsStream.hx
index aceb75f..2e29ed7 100644
--- a/snikket/streams/XmppJsStream.hx
+++ b/snikket/streams/XmppJsStream.hx
@@ -135,14 +135,11 @@ class XmppJsStream extends GenericStream {
 		#else
 		var request = new Http('https://$domain/.well-known/host-meta.json');
 		request.onData = function (data:String) {
-			try {
-				var parsed:HostMetaJson = Json.parse(data);
-				final links = parsed.links.filter((entry) -> entry.href.substr(0, 6) == "wss://");
-				if (links.length > 0) {
-					callback(links[0].href);
-					return;
-				}
-			} catch (e) {
+			final parsed:HostMetaJson = Json.parse(data);
+			final links = parsed.links.filter((entry) -> entry.href.substr(0, 6) == "wss://");
+			if (links.length > 0) {
+				callback(links[0].href);
+				return;
 			}
 			callback(null);
 		};