git » sdk » commit 819bcf4

Use @:access from tests not @:allow from code

author Stephen Paul Weber
2026-03-12 02:08:48 UTC
committer Stephen Paul Weber
2026-03-12 02:08:48 UTC
parent dfd61d1b3d3be56838111072668feb4e1690542b

Use @:access from tests not @:allow from code

borogove/ChatMessage.hx +1 -1
borogove/ChatMessageBuilder.hx +1 -1
borogove/Client.hx +1 -2
borogove/EventEmitter.hx +2 -2
borogove/GenericStream.hx +0 -1
borogove/Stanza.hx +0 -1
test/TestChatMessageBuilder.hx +1 -0
test/TestClient.hx +1 -0
test/TestSessionDescription.hx +1 -0

diff --git a/borogove/ChatMessage.hx b/borogove/ChatMessage.hx
index 16cefc4..659ca69 100644
--- a/borogove/ChatMessage.hx
+++ b/borogove/ChatMessage.hx
@@ -228,7 +228,7 @@ class ChatMessage {
 	@:allow(borogove)
 	public final versions: ReadOnlyArray<ChatMessage>;
 
-	@:allow(borogove, test)
+	@:allow(borogove)
 	private final payloads: ReadOnlyArray<Stanza>;
 
 	/**
diff --git a/borogove/ChatMessageBuilder.hx b/borogove/ChatMessageBuilder.hx
index 08ec391..5b2e94d 100644
--- a/borogove/ChatMessageBuilder.hx
+++ b/borogove/ChatMessageBuilder.hx
@@ -128,7 +128,7 @@ class ChatMessageBuilder {
 	**/
 	public var versions: Array<ChatMessage> = [];
 
-	@:allow(borogove, test)
+	@:allow(borogove)
 	private var payloads: Array<Stanza> = [];
 
 	/**
diff --git a/borogove/Client.hx b/borogove/Client.hx
index dd3080c..1825bb7 100644
--- a/borogove/Client.hx
+++ b/borogove/Client.hx
@@ -62,7 +62,6 @@ class Client extends EventEmitter {
 	**/
 	@:allow(borogove)
 	public var sendAvailable(null, default): Bool = true;
-	@:allow(test)
 	private var stream:GenericStream;
 	@:allow(borogove)
 	private var jid(default,null):JID;
@@ -113,7 +112,7 @@ class Client extends EventEmitter {
 	private final omemo: OMEMO;
 #end
 
-	@:allow(borogove, test)
+	@:allow(borogove)
 	private var inSync(default, null) = false;
 
 	/**
diff --git a/borogove/EventEmitter.hx b/borogove/EventEmitter.hx
index fb2396c..271a6ce 100644
--- a/borogove/EventEmitter.hx
+++ b/borogove/EventEmitter.hx
@@ -27,7 +27,7 @@ class EventEmitter {
 
 	private function new() { }
 
-	@:allow(borogove, test)
+	@:allow(borogove)
 	private function on(eventName:String, callback:EventCallback):EventHandlerToken {
 		var handlers = eventHandlers.get(eventName);
 		if(handlers == null) {
@@ -49,7 +49,7 @@ class EventEmitter {
 		});
 	}
 
-	@:allow(borogove, test)
+	@:allow(borogove)
 	private function trigger(eventName:String, eventData:Dynamic):EventResult {
 		final handlers = eventHandlers.get(eventName);
 		if (handlers == null) return EventUnhandled;
diff --git a/borogove/GenericStream.hx b/borogove/GenericStream.hx
index 5e2f2d9..4404049 100644
--- a/borogove/GenericStream.hx
+++ b/borogove/GenericStream.hx
@@ -39,7 +39,6 @@ abstract class GenericStream extends EventEmitter {
 		sendStanza(stanza);
 	}
 
-	@:allow(test)
 	private function onStanza(stanza:Stanza):Void {
 		trace("stanza received!");
 		final xmlns = stanza.attr.get("xmlns");
diff --git a/borogove/Stanza.hx b/borogove/Stanza.hx
index c6e7303..af76f7e 100644
--- a/borogove/Stanza.hx
+++ b/borogove/Stanza.hx
@@ -132,7 +132,6 @@ class Stanza {
 
 	#if (!cpp && !js)
 	@:allow(borogove)
-	@:allow(test)
 	private static function fromXml(el:Xml):Stanza {
 		if(el.nodeType == XmlType.Document) {
 			return fromXml(el.firstElement());
diff --git a/test/TestChatMessageBuilder.hx b/test/TestChatMessageBuilder.hx
index 0edcf49..0daf802 100644
--- a/test/TestChatMessageBuilder.hx
+++ b/test/TestChatMessageBuilder.hx
@@ -4,6 +4,7 @@ import utest.Assert;
 import utest.Async;
 import borogove.ChatMessageBuilder;
 
+@:access(borogove)
 class TestChatMessageBuilder extends utest.Test {
 	public function testConvertHtmlToXHTML() {
 		final msg = new ChatMessageBuilder();
diff --git a/test/TestClient.hx b/test/TestClient.hx
index ec50532..670db8e 100644
--- a/test/TestClient.hx
+++ b/test/TestClient.hx
@@ -7,6 +7,7 @@ import borogove.Client;
 import borogove.Stanza;
 import borogove.persistence.Dummy;
 
+@:access(borogove)
 class TestClient extends utest.Test {
 	public function testAccountId() {
 		final persistence = new Dummy();
diff --git a/test/TestSessionDescription.hx b/test/TestSessionDescription.hx
index 62ea256..fdc327a 100644
--- a/test/TestSessionDescription.hx
+++ b/test/TestSessionDescription.hx
@@ -5,6 +5,7 @@ import utest.Async;
 import borogove.Stanza;
 import borogove.calls.SessionDescription;
 
+@:access(borogove)
 class TestSessionDescription extends utest.Test {
 	final stanzaSource = '<iq type="set"><jingle sid="kxcebFwaWUQTQQO5sUoJJA" action="session-initiate" xmlns="urn:xmpp:jingle:1"><group semantics="BUNDLE" xmlns="urn:xmpp:jingle:apps:grouping:0"><content name="0"/></group><content name="0" creator="initiator" xmlns="urn:xmpp:jingle:1"><description media="audio" xmlns="urn:xmpp:jingle:apps:rtp:1"><payload-type channels="2" name="opus" clockrate="48000" id="111" xmlns="urn:xmpp:jingle:apps:rtp:1"><parameter name="minptime" value="10" xmlns="urn:xmpp:jingle:apps:rtp:1"/><parameter name="useinbandfec" value="1" xmlns="urn:xmpp:jingle:apps:rtp:1"/><rtcp-fb type="transport-cc" xmlns="urn:xmpp:jingle:apps:rtp:rtcp-fb:0"/></payload-type><payload-type channels="2" name="red" clockrate="48000" id="63" xmlns="urn:xmpp:jingle:apps:rtp:1"/><payload-type name="ISAC" clockrate="16000" id="103" xmlns="urn:xmpp:jingle:apps:rtp:1"/><payload-type name="ISAC" clockrate="32000" id="104" xmlns="urn:xmpp:jingle:apps:rtp:1"/><payload-type name="G722" clockrate="8000" id="9" xmlns="urn:xmpp:jingle:apps:rtp:1"/><payload-type name="ILBC" clockrate="8000" id="102" xmlns="urn:xmpp:jingle:apps:rtp:1"/><payload-type name="PCMU" clockrate="8000" id="0" xmlns="urn:xmpp:jingle:apps:rtp:1"/><payload-type name="PCMA" clockrate="8000" id="8" xmlns="urn:xmpp:jingle:apps:rtp:1"/><payload-type name="CN" clockrate="32000" id="106" xmlns="urn:xmpp:jingle:apps:rtp:1"/><payload-type name="CN" clockrate="16000" id="105" xmlns="urn:xmpp:jingle:apps:rtp:1"/><payload-type name="CN" clockrate="8000" id="13" xmlns="urn:xmpp:jingle:apps:rtp:1"/><payload-type name="telephone-event" clockrate="48000" id="110" xmlns="urn:xmpp:jingle:apps:rtp:1"/><payload-type name="telephone-event" clockrate="32000" id="112" xmlns="urn:xmpp:jingle:apps:rtp:1"/><payload-type name="telephone-event" clockrate="16000" id="113" xmlns="urn:xmpp:jingle:apps:rtp:1"/><payload-type name="telephone-event" clockrate="8000" id="126" xmlns="urn:xmpp:jingle:apps:rtp:1"/><rtp-hdrext uri="urn:ietf:params:rtp-hdrext:ssrc-audio-level" id="1" xmlns="urn:xmpp:jingle:apps:rtp:rtp-hdrext:0"/><rtp-hdrext uri="http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time" id="2" xmlns="urn:xmpp:jingle:apps:rtp:rtp-hdrext:0"/><rtp-hdrext uri="http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01" id="3" xmlns="urn:xmpp:jingle:apps:rtp:rtp-hdrext:0"/><rtp-hdrext uri="urn:ietf:params:rtp-hdrext:sdes:mid" id="4" xmlns="urn:xmpp:jingle:apps:rtp:rtp-hdrext:0"/><extmap-allow-mixed xmlns="urn:xmpp:jingle:apps:rtp:rtp-hdrext:0"/><source ssrc="3713170236" xmlns="urn:xmpp:jingle:apps:rtp:ssma:0"><parameter name="cname" value="KP3+b0QvXtga40Uo"/><parameter name="msid" value="- audio-track-76673976-daf1-4afa-bed8-1277ddc1c7f7"/></source><rtcp-mux/></description><transport pwd="88yXZajgGS00ziBDQ0yLtr9t" ufrag="r8tL" xmlns="urn:xmpp:jingle:transports:ice-udp:1"><fingerprint setup="actpass" hash="sha-256" xmlns="urn:xmpp:jingle:apps:dtls:0">26:58:C5:C5:68:7A:BA:C9:11:2D:6D:A3:C5:57:16:4C:E0:A0:46:06:FA:49:62:1B:54:E4:A5:F1:CB:89:18:43</fingerprint></transport></content></jingle></iq>';
 	final sdpExample =