git » sdk » commit b1fbd3c

Set subject should be over groupchat

author Stephen Paul Weber
2026-06-22 19:59:17 UTC
committer Stephen Paul Weber
2026-06-22 20:16:17 UTC
parent 2afe3c8390321b2445c0073f132f4bb4e086ef98

Set subject should be over groupchat

Apparently prosody does not require this...

borogove/Chat.hx +1 -2
test/TestChat.hx +1 -0

diff --git a/borogove/Chat.hx b/borogove/Chat.hx
index b4a8210..78129a4 100644
--- a/borogove/Chat.hx
+++ b/borogove/Chat.hx
@@ -1597,10 +1597,9 @@ class Channel extends Chat {
 		Set the Channel subject, or subject of a thread
 	**/
 	public function setSubject(subject: String, threadId: Null<String> = null) {
-		final outboxItem = outbox.newItem();
 		final stanza = new Stanza("message", { to: chatId }).textTag("subject", subject);
 		if (threadId != null) stanza.textTag("thread", threadId);
-		sendMessageStanza(stanza, outboxItem);
+		sendMessageStanza(stanza);
 	}
 
 	/**
diff --git a/test/TestChat.hx b/test/TestChat.hx
index 8ea724f..86e2704 100644
--- a/test/TestChat.hx
+++ b/test/TestChat.hx
@@ -354,6 +354,7 @@ class TestChat extends utest.Test {
 		client.stream.on("sendStanza", (stanza: Stanza) -> {
 			if (stanza.name == "message" && stanza.attr.get("to") == "channel@example.com") {
 				Assert.equals("New Subject", stanza.getChild("subject").getText());
+				Assert.equals("groupchat", stanza.attr.get("type"));
 				async.done();
 				return EventHandled;
 			}