git » sdk » commit d742319

Empty key is null key

author Stephen Paul Weber
2026-04-29 03:03:36 UTC
committer Stephen Paul Weber
2026-04-29 03:13:01 UTC
parent 02e852e2a3fa828101c1e388ad42e7ed15fe0ccb
Empty key is null key

Especially since the C API doesn't pass in null super reliably, we tend to interpret it as empty
borogove/Client.hx +1 -0 
diff --git a/borogove/Client.hx b/borogove/Client.hx
index 323254f..6cb3a03 100644
--- a/borogove/Client.hx
+++ b/borogove/Client.hx
@@ -1209,6 +1209,7 @@ class Client extends EventEmitter {
 		@param claims Optional additional JWT claims as key then value
 	**/
 	public function enablePush(push_service: String, endpoint: String, p256dh: BytesData, auth: BytesData, grace: Int, ?vapid_private_pkcs8: BytesData, ?claims: Array<String>) {
+		if (vapid_private_pkcs8 != null && Bytes.ofData(vapid_private_pkcs8).length == 0) vapid_private_pkcs8 = null;
 		enabledPushData = { push_service: push_service, vapid_private_pkcs8: vapid_private_pkcs8, endpoint: endpoint, p256dh: p256dh, auth: auth, grace: grace, claims: claims ?? [] };
 
 		final filters = [];