git » sdk » commit dd5ee3d

Do not sm/ack for stanza without id

author Stephen Paul Weber
2023-11-20 19:08:46 UTC
committer Stephen Paul Weber
2023-11-20 19:08:46 UTC
parent 60f39736997801f27b46f0aa7373b884d8546897

Do not sm/ack for stanza without id

xmpp/streams/XmppJsStream.hx +2 -2

diff --git a/xmpp/streams/XmppJsStream.hx b/xmpp/streams/XmppJsStream.hx
index 1cc95b2..ea7e0c8 100644
--- a/xmpp/streams/XmppJsStream.hx
+++ b/xmpp/streams/XmppJsStream.hx
@@ -182,12 +182,12 @@ class XmppJsStream extends GenericStream {
 			});
 
 			xmpp.on("stream-management/ack", (stanza) -> {
-				if (stanza.name == "message") this.trigger("sm/ack", { id: stanza.attrs.id });
+				if (stanza.name == "message" && stanza.attrs.id != null) this.trigger("sm/ack", { id: stanza.attrs.id });
 				triggerSMupdate();
 			});
 
 			xmpp.on("stream-management/fail", (stanza) -> {
-				if (stanza.name == "message") this.trigger("sm/fail", { id: stanza.attrs.id });
+				if (stanza.name == "message" && stanza.attrs.id != null) this.trigger("sm/fail", { id: stanza.attrs.id });
 				triggerSMupdate();
 			});